Improve phpdoc for ClassMetadataInfo #9965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Aug 6, 2022
derrabus
previously approved these changes
Aug 6, 2022
|
Hi @VincentLanglet I'll be AFK for a week, I saw there is a PR to fix the build, we can merge yours after that one |
|
See #9966 |
|
There is a lot of new errors, even with static analysis, but none are related to the PR. I'll wait for
then |
|
I took the liberty to rebase and squash your PR after having fixed the build on the 2.13.x branch. If the build is green, I'll merge. |
derrabus
approved these changes
Aug 7, 2022
|
Thank you @VincentLanglet! |
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 7, 2022
* 2.13.x: Address DBAL 3.4 deprecations (doctrine#9969) Improve phpdoc for ClassMetadataInfo (doctrine#9965) Fix build (doctrine#9964) fix: class normalisation test (doctrine#9966) Support native enum hydration when using `NEW` operator (doctrine#9936)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @greg0ire, this is a follow up of #9794.
Cc @derrabus #9794 (comment) There are less optional key.
Static analysis build is green. Tests are failing but this can't be related to my changes since I only touch phpdodc