Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psalm annotation for Entity attribute #9708

Merged
merged 1 commit into from
May 2, 2022

Conversation

michnovka
Copy link
Contributor

Fixes #9681

@michnovka
Copy link
Contributor Author

Since EntityRepository has already @template annotation declared, the only proper way is to always work with EntityRepository<T> in any psalm code. Not doing so is invalid psalm syntax, as can be seen here:
https://psalm.dev/r/d706b6cb58

@greg0ire greg0ire requested a review from derrabus May 1, 2022 19:06
@greg0ire greg0ire merged commit 26e274e into doctrine:2.12.x May 2, 2022
@greg0ire
Copy link
Member

greg0ire commented May 2, 2022

Thanks @michnovka !

@michnovka
Copy link
Contributor Author

np @greg0ire . When do you plan 2.12.2 patch release?

@derrabus derrabus added this to the 2.12.2 milestone May 2, 2022
@greg0ire
Copy link
Member

greg0ire commented May 2, 2022

@michnovka possibly this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity Annotation & EntityRepository Template causes Psalm Covariance Issues
5 participants