Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some ConnectionMock methods #9707

Merged
merged 1 commit into from
May 1, 2022
Merged

Remove some ConnectionMock methods #9707

merged 1 commit into from
May 1, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented May 1, 2022 •
edited
Loading

This patch is another step towards getting rid of using hard-coded mocks in the test suite for compatibility with DBAL 4:

  1. Do not use ConnectionMock in SequenceGeneratorTest.
  2. Remove unused ConnectionMock methods.

@morozov morozov requested review from greg0ire and derrabus and removed request for greg0ire May 1, 2022 14:10
@derrabus derrabus added this to the 2.12.2 milestone May 1, 2022
@derrabus derrabus merged commit 7f29b57 into doctrine:2.12.x May 1, 2022
@morozov morozov deleted the cleanup-connection-mock branch May 1, 2022 15:57
@morozov morozov mentioned this pull request May 1, 2022
Merged
@github-actions github-actions bot mentioned this pull request May 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
Test Suite
Projects
None yet
Milestone
2.12.2
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @derrabus