Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic property declarations #9683

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Apr 26, 2022

This PR fixes test failures on PHP 8.2. Declaring properties dynamically by simply assigning a value to it now emits a runtime deprecation. All cases that I could find were in our test suite only and they were 100% mistakes: Either the property did not exist by accident or we assigned to wrong property or the assignment was just unnecessary.

@derrabus derrabus added this to the 2.12.2 milestone Apr 26, 2022
@derrabus derrabus merged commit d9508e9 into doctrine:2.12.x Apr 26, 2022
@derrabus derrabus deleted the bugfix/dynamic-properties branch April 26, 2022 09:10
derrabus added a commit to derrabus/orm that referenced this pull request Apr 26, 2022
* 2.13.x:
  Remove dynamic property declarations (doctrine#9683)
  PHPStan 1.6.0 (doctrine#9682)
  Validate XML mapping against XSD file
  Document ORM drivers only really load ORM metadata
  Fix HydrationException::invalidDiscriminatorValue parameter type (doctrine#9676)
  Fix type on ClassMetadata discriminatorMap (doctrine#9675)
derrabus added a commit to derrabus/orm that referenced this pull request Apr 27, 2022
* 2.13.x:
  PHPStan 1.6.1 (doctrine#9688)
  Drop SymfonyStyle[listing] for sqls (doctrine#9679)
  Remove dynamic property declarations (doctrine#9683)
  PHPStan 1.6.0 (doctrine#9682)
  Validate XML mapping against XSD file
  Document ORM drivers only really load ORM metadata
  Fix HydrationException::invalidDiscriminatorValue parameter type (doctrine#9676)
  Fix type on ClassMetadata discriminatorMap (doctrine#9675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants