Fix type errors with XML export on PHP 8.1 #9589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see PHP interface SimpleXMLElement::addAttribute(string $name, string $value = null, string $namespace = null): void .... The $value must be string or null.
|
Blocked by #9590 |
greg0ire
approved these changes
Mar 18, 2022
derrabus
approved these changes
Mar 19, 2022
derrabus
changed the title
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Mar 28, 2022
* 2.12.x: Update psalm.xml PHPStan 1.5.0 (doctrine#9607) Remove Sphinx config Indicate what feature is deprecated Implement int-mask-of where appropriate Use correct syntax for external links Update XmlExporter.php - Type problem in php8.x (doctrine#9589) Ignore deprecation from Persistence Stands with Ukraine (doctrine#9567) Use internal links when self-referencing Link to docs for the stable version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see PHP interface SimpleXMLElement::addAttribute(string $name, string $value = null, string $namespace = null): void ....
The $value must be string or null.