Fix type on SqlWalker::walkPathExpression()
#9565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Mar 6, 2022
Comment on lines
-33
to
-36
| public function dispatch($sqlWalker) | ||
| { | ||
| return $sqlWalker->walkPathExpression($this); | ||
| } |
There was a problem hiding this comment.
I've removed this method because there's no way a call to this method could've returned anything. The parent class contains an implementation of that method that raises a proper exception, so it seems just right to fall back to that.
greg0ire
approved these changes
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter of
SqlWalker::walkPathExpression()is annotated asmixed, but passing anything but aPathExpressionto it would result in an error because the method accesses properties on the passed value.