Bring FilterCollection to a "clean" state after hash computation

[mpdude]

Improvement

Q	A
New Feature	no
RFC	no
BC Break	no

Effectively, the FilterCollection was never brought back into a "clean" state after filters were enabled or filter parameters were set.

As far as I can tell, the clean/dirty distinction only refers to the computed FilterCollection hash reflecting all enabled filters and their parameters.

The only place I could find where the distinction matters is here:

orm/lib/Doctrine/ORM/Query.php

Lines 241 to 259 in 152c04c

	// Return previous parser result if the query and the filter collection are both clean
	if ($this->_state === self::STATE_CLEAN && $this->parsedTypes === $types && $this->_em->isFiltersStateClean()) {
	return $this->parserResult;
	}
	$this->_state = self::STATE_CLEAN;
	$this->parsedTypes = $types;
	$queryCache = $this->queryCache ?? $this->_em->getConfiguration()->getQueryCache();
	// Check query cache.
	if (! ($this->useQueryCache && $queryCache)) {
	$parser = new Parser($this);
	$this->parserResult = $parser->parse();
	return $this->parserResult;
	}
	$cacheItem = $queryCache->getItem($this->getQueryCacheId());

When the filter collection is dirty and the query cache is used, the call to getQueryCacheId() in the last line shown will reset the filter collection to a clean state.

When there is no query cache, however, getQueryCacheId() is not called and the FilterCollection will not revert to a clean state; this prevents re-using the query later on.

If desired, I could add a FilterCollection::setFiltersStateClean() method to improve this case as well.

Closes #9521

[derrabus]

Thank you. Can you please provide a test that reproduces the issue that your attempt to fix?

[mpdude]

Can you please provide a test that reproduces the issue that your attempt to fix?

I don't know what I am trying to fix here 🐼 .

I came across this clean/dirty state distinction and figured it makes no sense the way it is implemented right now.

This PR is my guess what the original author might have intended and I'd be glad if this gets a bit more scrutiny.

[derrabus]

I've added a test.