-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added php 8.1 to CI #9440
Added php 8.1 to CI #9440
Conversation
Modifications to the CI should target the lowest maintained branch instead (2.11.x currently). That being said, we already do test on PHP 8.1. Can you elaborate why you wanted to change the PHP version on those jobs specifically? |
I saw that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the question is, what should we use for testing platform-specific code? The answer is probably: either the lowest or the highest PHP version. To me, it makes sense to use the highest here, as we are more likely to be using DBAL code we have never been exposed to that way, and catch new bugs.
The build is failing, is that what is happening here? 😅 EDIT: the failing test is |
It is a better default, and should fix tests for PostgreSQL
This is why #8931 is important |
Thanks @sir-kain ! |
Jobs updated: