Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added php 8.1 to CI #9440

Merged
merged 2 commits into from
Jan 30, 2022
Merged

Added php 8.1 to CI #9440

merged 2 commits into from
Jan 30, 2022

Conversation

sir-kain
Copy link
Contributor

Jobs updated:

  • phpunit-postgres
  • phpunit-mariadb
  • phpunit-mysql

@derrabus
Copy link
Member

Modifications to the CI should target the lowest maintained branch instead (2.11.x currently). That being said, we already do test on PHP 8.1. Can you elaborate why you wanted to change the PHP version on those jobs specifically?

@derrabus derrabus added the CI label Jan 28, 2022
@greg0ire greg0ire changed the base branch from 3.0.x to 2.11.x January 28, 2022 22:45
@sir-kain
Copy link
Contributor Author

sir-kain commented Jan 28, 2022

Modifications to the CI should target the lowest maintained branch instead (2.11.x currently). That being said, we already do test on PHP 8.1. Can you elaborate why you wanted to change the PHP version on those jobs specifically?

I saw that phpstan, phpcs, psalm, ... PHP version are all on 8.1 on the CI and I wanted to use the same version everywhere by default.

greg0ire
greg0ire previously approved these changes Jan 28, 2022
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the question is, what should we use for testing platform-specific code? The answer is probably: either the lowest or the highest PHP version. To me, it makes sense to use the highest here, as we are more likely to be using DBAL code we have never been exposed to that way, and catch new bugs.

@greg0ire
Copy link
Member

greg0ire commented Jan 28, 2022

we are more likely to be using DBAL code we have never been exposed to that way, and catch new bugs.

The build is failing, is that what is happening here? 😅

EDIT: the failing test is Doctrine\Tests\ORM\Functional\ReadonlyPropertiesTest, which is probably why this wasn't caught before (that test did not run at all for PostgreSQL)

It is a better default, and should fix tests for PostgreSQL
@greg0ire
Copy link
Member

This is why #8931 is important

@greg0ire greg0ire merged commit c1b131b into doctrine:2.11.x Jan 30, 2022
@greg0ire
Copy link
Member

Thanks @sir-kain !

@derrabus derrabus added this to the 2.11.1 milestone Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants