Use the readonly annotation #9340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jan 9, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 9, 2022
* 2.11.x: PHPStan 1.3.3, Psalm 4.18.1 Remove Psalm job for analyzing DBAL 2 Use the readonly annotation (doctrine#9340) Add support for custom types with requireSQLConversion and ResultSetMappingBuilder::generateSelectClause() PSR-6 second level cache Fix type errors in AbstractQuery and QueryBuilder (doctrine#9275) Mark columnName as always set Add support for PHP 8.1 enums. Remove ignore rules for issues fixed upstream (doctrine#9336) [doctrineGH-9277] deprecate php driver (doctrine#9309)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 9, 2022
* 2.11.x: PHPStan 1.3.3, Psalm 4.18.1 Remove Psalm job for analyzing DBAL 2 Use the readonly annotation (doctrine#9340) Add support for custom types with requireSQLConversion and ResultSetMappingBuilder::generateSelectClause() PSR-6 second level cache Fix type errors in AbstractQuery and QueryBuilder (doctrine#9275) Mark columnName as always set Add support for PHP 8.1 enums. Remove ignore rules for issues fixed upstream (doctrine#9336) [doctrineGH-9277] deprecate php driver (doctrine#9309)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 9, 2022
* 2.11.x: PHPStan 1.3.3, Psalm 4.18.1 Remove Psalm job for analyzing DBAL 2 Use the readonly annotation (doctrine#9340) Add support for custom types with requireSQLConversion and ResultSetMappingBuilder::generateSelectClause() PSR-6 second level cache Fix type errors in AbstractQuery and QueryBuilder (doctrine#9275) Mark columnName as always set Add support for PHP 8.1 enums. Remove ignore rules for issues fixed upstream (doctrine#9336) [doctrineGH-9277] deprecate php driver (doctrine#9309)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several public properties are documented as
READ-ONLY: <some explanation>. However, in the meantime, PHP has implemented realreadonlyproperties and Psalm supports the docblock annotation@readonlyto emulate its sematics.https://psalm.dev/docs/annotating_code/supported_annotations/#psalm-readonly-and-readonly
I propose to switch to that annotation to allow Psalm to detect unintended access to those properties.
Note: I have skipped the
ClassMetadataInfoclass because most of the properties flagged asREAD-ONLYthere are actually not used accoding to PHP 8.1's semantics.