Added runtime deprecation to UnitOfWork::commit() and clear()
#9327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
changed the title
UnitOfWork::commit()UnitOfWork::commit() and clear()
greg0ire
approved these changes
Jan 5, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 5, 2022
* 2.11.x: Added runtime deprecation to `UnitOfWork::commit()` and `clear()` (doctrine#9327) Document return type of getEntityState() (doctrine#9328) Fix broken type declaration (doctrine#9330) Enable some previously disabled PHPCS rules (doctrine#9324)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8459. Passing an entity or a set of them to
UnitOfWork::commit()is deprecated since ORM 2.7 (along withEntityManager::flush($entity)), but no runtime deprecation has been triggered so far when calling the UoW directly.Same for
UnitOfWork::clear().This PR attempts to correct that.