Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessing private properties and methods from the same class is forbidden #9311

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Accessing private properties and methods from the same class is forbidden #9311

merged 1 commit into from
Jan 17, 2022

Conversation

olsavmic
Copy link
Contributor

@olsavmic olsavmic commented Jan 1, 2022 •
edited
Loading

@olsavmic olsavmic mentioned this pull request Jan 1, 2022
Closed
@olsavmic olsavmic force-pushed the patch-1 branch 2 times, most recently from 8dbf940 to 057df98 Compare January 1, 2022 19:33
@derrabus derrabus changed the base branch from 2.10.x to 2.11.x January 12, 2022 13:34
@olsavmic
Accessing private properties and methods from the same class is forbi…
9e0a097 
…dden

Resolves issue doctrine/common#934

Update docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst

Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com>

Update docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst

Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com>

Fix review issues
SenseException
SenseException approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the content and need another pair of eyes.

@derrabus derrabus added this to the 2.11.1 milestone Jan 17, 2022
@derrabus derrabus merged commit a2a7d5b into doctrine:2.11.x Jan 17, 2022
derrabus added a commit that referenced this pull request Jan 18, 2022
@derrabus @javer @olsavmic
Merge 2.11.x into 2.12.x (#9394)
2886d0d 
* Expose enumType to DBAL to make native DB Enum possible (#9382)

* Accessing private properties and methods from the same class is forbidden (#9311)

Resolves issue doctrine/common#934

Update docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst

Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com>

Update docs/en/cookbook/accessing-private-properties-of-the-same-class-from-different-instance.rst

Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com>

Fix review issues

* Update baselines for DBAL 3.3 (#9393)

Co-authored-by: Vadim Borodavko <vadim.borodavko@gmail.com>
Co-authored-by: olsavmic <molsavsky1@gmail.com>
derrabus added a commit to derrabus/orm that referenced this pull request Jan 18, 2022
@derrabus
Merge branch '2.12.x' into 3.0.x
3999837 
* 2.12.x:
  Deprecate MultiGetRegion (doctrine#9397)
  Fix type on loadCacheEntry (doctrine#9398)
  Update baselines for DBAL 3.3 (doctrine#9393)
  Accessing private properties and methods from the same class is forbidden (doctrine#9311)
  Expose enumType to DBAL to make native DB Enum possible (doctrine#9382)
@github-actions github-actions bot mentioned this pull request Jan 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@derrabus derrabus derrabus approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
2.11.1
Development

Successfully merging this pull request may close these issues.

Proxies - Access to private property from the same class scope (recursive) does not initialise Proxy
3 participants
@olsavmic @SenseException @derrabus