Put actual value instead of index inside $originalEntityData #9244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
changed the title
|
Can you have a look at the failing tests? |
This fixes a bug with redundant UPDATE queries, that are executed when some entity uses foreign index of other entity as a primary key. This happens when after inserting related entities with $em->flush() call, you do the second $em->flush() without changing any data inside entities. Fixes GH8217.
|
Yes, sorry. They failed because I used wrong php language level (7.4 instead of 7.1). Now should be fine. |
derrabus
approved these changes
Dec 21, 2021
derrabus
added a commit
that referenced
this pull request
Dec 26, 2021
* Better explain limitations of DQL "DELETE" (#9281) We think the current documentation does not stress these details enough, so that they are easily overlooked. Co-authored-by: Malte Wunsch <mw@webfactory.de> Co-authored-by: Malte Wunsch <mw@webfactory.de> * Put actual value instead of index inside $originalEntityData. (#9244) This fixes a bug with redundant UPDATE queries, that are executed when some entity uses foreign index of other entity as a primary key. This happens when after inserting related entities with $em->flush() call, you do the second $em->flush() without changing any data inside entities. Fixes GH8217. Co-authored-by: ivan <ivan.strygin@managinglife.com> * Allow symfony/cache 6 (#9283) * Fix XML export for `change-tracking-policy` (#9285) * Whitelist composer plugins used by this repository (#9286) Co-authored-by: Matthias Pigulla <mp@webfactory.de> Co-authored-by: Malte Wunsch <mw@webfactory.de> Co-authored-by: Ivan Strygin <feolius@gmail.com> Co-authored-by: ivan <ivan.strygin@managinglife.com> Co-authored-by: Fedir Zinchuk <getthesite@gmail.com>
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 26, 2021
* 2.11.x: Enable UnusedUse sniff again (doctrine#9267) Whitelist composer plugins used by this repository (doctrine#9286) Fix XML export for `change-tracking-policy` (doctrine#9285) Allow symfony/cache 6 (doctrine#9283) Put actual value instead of index inside $originalEntityData. (doctrine#9244) Fix return types of cache interfaces (doctrine#9271) Better explain limitations of DQL "DELETE" (doctrine#9281) Fix docblocks on nullable EM properties (doctrine#9273) Docs: use canonical order for phpdoc tags, add missed semicolon (doctrine#9190) Make PrimaryReadReplicaConnection enforcement explicit (doctrine#9239) Regenerate Psalm baseline (doctrine#9272) Improve compatibility with Doctrine DBAL 4 (doctrine#9266) [docs] Fix wording for attributes=>parameters. (doctrine#9265) Support for nesting attributes with PHP 8.1 (doctrine#9241) Revert "Fix SchemaValidator with abstract child class in discriminator map (doctrine#9096)" (doctrine#9262) Docs: consistency for FQCN, spacing, etc (doctrine#9232)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with redundant UPDATE queries, that are executed when some entity uses foreign index of other entity as a primary key. This happens when after inserting related entities with $em->flush() call, you do the second $em->flush() without changing any data inside entities.
Fixes #8217.