Support for DBAL 3's platform classes #8946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Aug 22, 2021
| use function get_class; | ||
| use function sprintf; | ||
|
|
||
| // DBAL 2 compatibility | ||
| class_exists('Doctrine\DBAL\Platforms\MySqlPlatform'); |
There was a problem hiding this comment.
That's a tricky one. The class name was changed from MySqlPlatform to MySQLPlatform. Class names are case-insensitive in PHP, so just using the new name would theoretically work. However, on a case-sensitive filesystem, autoloading would fail if the case does not match. This is why I'm triggering the autoloader with old and new class name.
greg0ire
reviewed
Aug 22, 2021
lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php
Outdated
Show resolved
Hide resolved
derrabus
force-pushed
the
bugfix/dbal-3-platforms
branch
2 times, most recently
from
e94153d
to
4ec8eda
Compare
derrabus
force-pushed
the
bugfix/dbal-3-platforms
branch
4 times, most recently
from
4f1ec5c
to
24407e5
Compare
Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus
force-pushed
the
bugfix/dbal-3-platforms
branch
from
24407e5
to
fdbc6b6
Compare
|
PR is ready again. |
greg0ire
reviewed
Aug 29, 2021
greg0ire
approved these changes
Aug 29, 2021
|
Thanks @derrabus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DBAL 3, various platform classes have been removed or renamed. Furthermore, DBAL 3.2 will deprecate the
AbstractPlatform::getName()method.This PR makes the necessary adjustments in ORM.