Address Type deprecation messages #8915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Aug 12, 2021
This was
linked to
issues
Aug 12, 2021
|
This results in 14 fewer errors in both Psalm and Phpstan DBAL 3 jobs 🙂 |
This makes us more compatible with DBAL v3. We didn't address Type::JSON_ARRAY because it has been removed
greg0ire
force-pushed
the
address-type-deprecation
branch
from
f333125
to
40f6131
Compare
|
Found more occurrences in tests. There is no static analysis on tests. Also, for reference this PR introduced the deprecations: doctrine/dbal#3356 |
greg0ire
approved these changes
Aug 12, 2021
SenseException
approved these changes
Aug 12, 2021
|
Thanks @basseta ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes us more compatible with DBAL v3.
We didn't address
Type::JSON_ARRAYbecause it has been removedRefs #8884, #8885