CS batch 7/an estimated 30 #8474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That comment is mistaken for a method comment because it precedes one. The issue was reported but will most likely not be fixed.
These files must be require'd
SenseException
approved these changes
Feb 12, 2021
| * @OneToOne(targetEntity="MappedSuperclassRelated1") | ||
| * @JoinColumn(name="related1_id", referencedColumnName="id") | ||
| */ | ||
| private $mappedRelated1; | ||
|
|
||
| /** @var mixed */ | ||
| private $transient; | ||
| } | ||
| class MappedSuperclassRelated1 |
There was a problem hiding this comment.
I'm surprised that the coding standard is not complaining about the missing new line between classes.
There was a problem hiding this comment.
It's surprising indeed, I'll add one in my next PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 2512 to 2399 errors