Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid psalm annotation #8374

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Fix invalid psalm annotation #8374

merged 1 commit into from
Dec 5, 2020

Conversation

micheh
Copy link
Contributor

@micheh micheh commented Dec 5, 2020

The psalm annotation is currently invalid and psalm outputs an error:
ERROR: InvalidDocblock - vendor/doctrine/orm/lib/Doctrine/ORM/EntityRepository.php:74:5 - Badly-formatted @param in docblock for Doctrine\ORM\EntityRepository::__construct (see https://psalm.dev/008)

@greg0ire greg0ire added the Bug label Dec 5, 2020
@greg0ire greg0ire merged commit cab7a45 into doctrine:2.8.x Dec 5, 2020
@greg0ire
Copy link
Member

greg0ire commented Dec 5, 2020

Thanks @micheh!

@EtchAkhtar
Copy link

@greg0ire Hi Greg, is there an idea when this will make it into a release?

@greg0ire greg0ire added this to the 2.8.2 milestone Jan 14, 2021
@greg0ire
Copy link
Member

I think it will be released during this quarter. 🔮

@7ochem
Copy link

7ochem commented Feb 15, 2021

While awaiting the release and for anyone else running into this issue, I ignored the error for now using:

<!-- @TODO: Remove this when https://github.com/doctrine/orm/issues/8395 is resolved -->
<issueHandlers>
   <InvalidDocblock>
       <errorLevel type="info">
           <file name="vendor/doctrine/orm/lib/Doctrine/ORM/EntityRepository.php" />
       </errorLevel>
   </InvalidDocblock>
</issueHandlers>

@EtchAkhtar
Copy link

While awaiting the release and for anyone else running into this issue, I ignored the error for now using:

<!-- @TODO: Remove this when https://github.com/doctrine/orm/issues/8395 is resolved -->
<issueHandlers>
   <InvalidDocblock>
       <errorLevel type="info">
           <file name="vendor/doctrine/orm/lib/Doctrine/ORM/EntityRepository.php" />
       </errorLevel>
   </InvalidDocblock>
</issueHandlers>

@7ochem this is amazing ... just what I needed. I disabled psalm checks in our CI, now I can add them back, thank you so much

@greg0ire
Copy link
Member

Prediction fulfilled: https://github.com/doctrine/orm/releases/tag/2.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants