Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EntityManagerHelper's documentation (it can't accept an array of paths) #7768

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

mickaelandrieu
Copy link
Contributor

No description provided.

@greg0ire
Copy link
Member

greg0ire commented Jul 4, 2019

This branch is no longer maintained, you should probably target 2.6

@greg0ire greg0ire changed the base branch from 2.5 to 2.6 September 28, 2019 10:30
@greg0ire
Copy link
Member

I had a look at the history, it looks like this argument never existed, this is fishy…

@mickaelandrieu
Copy link
Contributor Author

So weird! Maybe the pull request for docs has been done at the same time as the contribution but the contribution was rejected?

👼

@greg0ire
Copy link
Member

greg0ire commented Oct 1, 2019

It was introduced in 997ef97 , which is the 8th commit in this repository, 9 years ago :P There didn't seem to be PRs at the time. Also, there was no code yet, it was just docs… EntityManagerHelper was introduced later on , in 5854bca … go figure !

@lcobucci lcobucci self-assigned this Oct 1, 2019
@lcobucci lcobucci added this to the 2.6.5 milestone Oct 1, 2019
@lcobucci lcobucci merged commit f08ff83 into doctrine:2.6 Oct 1, 2019
@lcobucci
Copy link
Member

lcobucci commented Oct 1, 2019

@mickaelandrieu thanks!

@lcobucci lcobucci changed the title EntityManagerHelper can't accept an array of paths Fix EntityManagerHelper's documentation (it can't accept an array of paths) Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants