#7763 escape quotes in field comments #7764
Conversation
There was a problem hiding this comment.
Thank you for your pull request. Please fix these 2 cs issues:
FILE: lib/Doctrine/ORM/Tools/EntityGenerator.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1682 | ERROR | [x] Function str_replace() should not be referenced via a
| | fallback global name, but via a use statement.
| | (SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFallbackGlobalName)
1682 | ERROR | [x] Concat operator must be surrounded by a single space
| | (Squiz.Strings.ConcatenationSpacing.PaddingFound)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
|
I did the change, i don't know the process now :) |
There was a problem hiding this comment.
This PR is probably fine, but be aware that entity creation with the EntityGenerator was dropped in the next major release and that there won't be a generator or a generator command anymore: https://github.com/doctrine/orm/blob/master/UPGRADE.md#bc-break-removed-code-generators-and-related-console-commands
|
Thanks. |
There was a problem hiding this comment.
@guillaume-a this PR completely passed by my reviews, sorry. As mentioned before, this class is going to die a terrible death but I'm fine with patching it up once more.
|
@guillaume-a thanks for your contribution 👍 |
This is my attempt to PR this.
Tell me if it's okay or not.