Fix MEMBER_OF comparison when using criteria in query builder

[Smartel1]

Fixes "Unknown comparison operator: MEMBER_OF" exception when apply Criteria memberOf comparison to queryBuilder

[greg0ire]

Looks fine to me. Are there any docs that need to be updated/or tests that need to be written?

[Smartel1]

Im not sure. I will check it tommorrow

[vudaltsov]

Please, add a relevant test case to data provider at https://github.com/doctrine/orm/blob/2.6/tests/Doctrine/Tests/ORM/Query/QueryExpressionVisitorTest.php#L54.

[kevinpapst]

Just ran into this issue. Since it has two approvals, what about merging?

[Smartel1]

Can I merge by myself? Or what’s the question?

[lcobucci]

It hasn't been merged because IMHO this should be considered as an improvement and not a bug fix, so should be sent to branch 2.7 or master.

[kevinpapst]

There is a public API method Criteria::expr()->memberOf() which runs into an exception when used. One could argue that this feels like a bug ...

[lcobucci]

@kevinpapst my bad, the title and the patch mislead me. It would be crucial to have a functional test case for it then. I'll rebase this branch and add it.

---

Edit: I've rebased the branch and created a test but the error described in the first comment is a bit misleading so I'd like to clarify one tiny thing: can you please send us a tiny snippet of the issue? Just the query builder calls.

We're missing functional tests here

[Smartel1]

$criterion = Criteria::create()->andWhere(
Criteria::expr()->memberOf(':user', 'e.likedUsers')
);

$qb->addCreiteria($criterion);

[lcobucci]

@Smartel1 🚢