Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing type in Query::getFirstResult PHPDoc #7298

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Jul 5, 2018

To prevent false positives with static analysis tools.

@teohhanhui
Copy link
Contributor

We look forward to being able to remove this false positive:

https://github.com/api-platform/core/blob/d33b6d22817ae45f0f2598b6657e0576d0344f95/phpstan.neon.dist#L84-L85

@greg0ire
Copy link
Member

greg0ire commented Jun 7, 2019

Should line 159 be changed as well?

azjezz
azjezz previously approved these changes Jun 16, 2019
lcobucci
lcobucci previously approved these changes Oct 2, 2019
@lcobucci lcobucci self-assigned this Oct 2, 2019
@lcobucci lcobucci added this to the 2.6.5 milestone Oct 2, 2019
@lcobucci lcobucci merged commit 16df8bf into doctrine:2.6 Oct 2, 2019
@lcobucci
Copy link
Member

lcobucci commented Oct 2, 2019

@dunglas thanks 👍

@dunglas dunglas deleted the patch-2 branch October 2, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants