Fixed usage of undefined variable in empty() expression in SqlWalker
#6621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed $conditions to $condition so $isConditionalJoin is working
|
I must say that I have issues wrapping my head around the fact that builds fail on Still, this is why you don't use Thanks @Powerhamster, I'm doing a fixup release with this patch in it ASAP |
Ocramius
changed the title
empty() expression in SqlWalker
jvasseur
reviewed
Aug 13, 2017
| @@ -1143,7 +1143,7 @@ public function walkJoin($join) | |||
| $dqlAlias = $joinDeclaration->aliasIdentificationVariable; | |||
| $tableAlias = $this->getSQLTableAlias($class->table['name'], $dqlAlias); | |||
| $condition = '(' . $this->walkConditionalExpression($join->conditionalExpression) . ')'; | |||
| $isUnconditionalJoin = empty($conditions); | |||
| $isUnconditionalJoin = empty($condition); | |||
There was a problem hiding this comment.
Wouldn't this be always true given the previous line always add brackets to the $condition variable meaning it will never be empty ?
There was a problem hiding this comment.
@jvasseur yes, that's not an issue though, as the code was cleaned up on master
There was a problem hiding this comment.
Should I try to fix it?
There was a problem hiding this comment.
@Powerhamster no - ORM 2.5.8 is green and doesn't need improvement here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed $conditions to $condition so $isConditionalJoin is working