EntityManager::__cosntruct() as public method

[mcspronko]

Updated EntityManager::__construct() method to public visibility:

• moved create() method to EntityManagerFactory class
• added new Configuration class methods for UnitOfWork and ProxyFactory classes
• updated documentation
• updated unit and functional tests

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3550

We use Jira to track the state of pull requests and the versions they got
included in.

[fprochazka]

removing this method would an unnecesary BC Break

[stekycz]

agree

[mcspronko]

As for now EntityManager has a lot of responsibilities including creation of its own instance. Separate class should prepare and instantiate EntityManager. I agree that this is backward incompatible change. The strategy might be changed based on release policy. In case 2.5.* allows to introduce this change, we are in a good shape. Alternatively, this method might marked as @deprecated since 2.5 and proxy behavior to the EntityManagerFactory
Like this:

    /**
     * @deprecated since 2.5
     */
    public static function create($conn, Configuration $config, EventManager $eventManager = null)
    {
        return new EntityManagerFactory($conn, $config, $eventManager);
    }

Thanks

[stof]

@mcspronko BC breaks are forbidden in minor versions. Semver means that any BC break in the public API requires bumping the major version

[mcspronko]

@stof so option with deprecated create() method should be ok for minor change.

[fprochazka]

You can mark it deprecated, but you cannot change the behaviour.

[mcspronko]

Agree, my mistake it should be like this

    /**
     * @deprecated since 2.5
     */
    public static function create($conn, Configuration $config, EventManager $eventManager = null)
    {
        return EntityManagerFactory::create($conn, $config, $eventManager);
    }

where create() behavior is the same.
Thanks

[fprochazka]

why do you have the new there?

[mcspronko]

TYPO :)

[Majkl578]

EntityManager::__construct() is not public by design and EntityManager::create() is the only exposed and proper way to instantiate new instance. Also EntityManager will become final in Doctrine 3.0.
Additionally configuring UnitOfWork class name shouldn't be possible, it is not intended to be extended or replaced as it contains pretty sensitive code.

Valid extension point to enhance EntityManager is through decorator pattern using EntityManagerInterface, not inheritance.
If you still think this is needed and want to update this PR (if so, please on top of develop branch), let me know and I will reopen. I think extracting factory to separate class could be eventually considered, but not configurable UnitOfWork. Thanks.