Hotfix - #1169 - extra lazy one to many must be no-op when not doing orphan removal #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges should be no-op unless orphan removal is specified.
…nges should be no-op unless orphan removal is specified.
…on should not be updated directly if no orphan removal is involved
… + one-to-many element removal behavior
…n-removal, referenced entities should be deleted directly
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3544 We use Jira to track the state of pull requests and the versions they got |
…ed cache entries should be evicted to avoid collisions with DB state
… a delete operation down to the DB
… a delete operation down to the DB
| @@ -485,7 +486,7 @@ public function testRemoveElementOneToMany() | |||
|
|
|||
| $this->assertFalse($user->articles->isInitialized(), "Post-Condition: Collection is not initialized."); | |||
| // NOTE: +2 queries because CmsArticle is a versioned entity, and that needs to be handled accordingly | |||
There was a problem hiding this comment.
This comment can be removed, right?
Ocramius
added a commit
that referenced
this pull request
Jan 28, 2015
…-many-is-noop-when-not-doing-orphan-removal Hotfix - #1169 - extra lazy one to many must be no-op when not doing orphan removal
Ocramius
deleted the
hotfix/#1169-extra-lazy-one-to-many-is-noop-when-not-doing-orphan-removal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1281 (comment)
Linking #1169