-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation of supported MariaDB releases #6407
Conversation
@@ -6,7 +6,7 @@ | |||
use Doctrine\DBAL\Schema\TableDiff; | |||
|
|||
/** | |||
* Provides the behavior, features and SQL dialect of the MariaDB 10.5 (10.5.2 GA) database platform. | |||
* Provides the behavior, features and SQL dialect of the MariaDB 10.5 (10.5.2 Beta) database platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10.5.2 is not a GA, but a beta release. Not sure if that suffix provides any value though. Maybe we should drop the suffix (and even the patch level) from this documentation, since nobody can really expect us to support ancient alpha/beta releases of any database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifying the patch level allows us to explicitly say that we don't support 10.5.1, and never will, so there's that. I agree that it's not really our role to remind our users what stability a specific patch version is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the patch level in the docs now, but dropped them from the platform classes. WDYT?
9170ca4
to
249d2e7
Compare
@greg0ire The CodeCov upload failed:
https://github.com/doctrine/dbal/actions/runs/9111667720/job/25049918068?pr=6407 |
* 3.8.x: Fix documentation of supported MariaDB releases (#6407)
* 3.8.x: Fix documentation of supported MariaDB releases (#6407)
* 4.0.x: Fix documentation of supported MariaDB releases (#6407)
* 4.1.x: Fix documentation of supported MariaDB releases (#6407)
Sadly, I don't think there is anything we can do against that :( |
No description provided.