Add direct dependency on PHP_CodeSniffer #4593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Apr 9, 2021
|
Approving for the sake of fixing the build, but I really think referencing a rule in a file is enough motive to consider this a direct dependency, see #4592 (comment) |
morozov
changed the title
Valid point. Please see the update. |
greg0ire
approved these changes
Apr 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the build failure of #4592.
PHP_CodeSniffer 3.6.0 introduces changes of some error codes suppressed in the codebase (e.g. squizlabs/PHP_CodeSniffer@0aeb095).
Since it's an indirect dependency currently restricted to
^3.5.6byslevomat/coding-standard, without restricting it directly, the repository would have to maintain compatibility with both 3.5 and 3.6. The solution is to restrict it temporarily until it's restricted by a direct dependency.