Reintroduce parts of Legacy API for some more time #4317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
reviewed
Oct 3, 2020
morozov
reviewed
Oct 6, 2020
morozov
reviewed
Oct 7, 2020
|
@morozov added the typehints and cleanuped everything, last point is the test, i used |
|
@beberlei, see |
…ment) for a longer period than 2.x.
beberlei
changed the title
morozov
approved these changes
Oct 9, 2020
|
Thanks, @beberlei. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this PR we are re-introducing the PDO compatible API and common APIs of the DBAL "hotpath" again to keep them for a bit longer. This is too give users more time to migrate off of them, especially since many libraries and frameworks expose Doctrine DBAL via their plugin APIs.