Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update architecture documentation #4164

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Update architecture documentation #4164

merged 1 commit into from
Jul 11, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jul 11, 2020

Q A
Type improvement
BC Break no

@morozov morozov added this to the 3.0.0 milestone Jul 11, 2020
@morozov morozov requested a review from greg0ire July 11, 2020 06:22
@morozov morozov mentioned this pull request Jul 11, 2020
Merged
1 task
greg0ire
greg0ire reviewed Jul 11, 2020
View reviewed changes
docs/en/reference/architecture.rst Outdated
``Doctrine\DBAL\Statement`` add to the underlying driver
The DBAL consists of two layers: drivers and a wrapper. Each layer
is mainly defined in terms of 3 components: ``Connection``,
```Statement`` and ``Result``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my phone, but too many backticks here

docs/en/reference/architecture.rst Outdated
Apart from the three main components, a DBAL driver should also provide
an implementation of the ``Doctrine\DBAL\Driver`` interface that
implements the logic of translation of the DBAL connection parameters
to the ones specific to the given driver and provides factory methods
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the interface provide the factory methods? If not no s after provide

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was about "interface … provides" but it's clumsy and the sentence is too complex. Let me try to rephrase.

@morozov morozov merged commit 12793ff into doctrine:3.0.x Jul 11, 2020
@morozov morozov self-assigned this Jul 11, 2020
@morozov morozov deleted the architecture branch July 11, 2020 17:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
Documentation Improvement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire