Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark driver classes final #4147

Merged
merged 2 commits into from
Jul 5, 2020
Merged

Mark driver classes final #4147

merged 2 commits into from
Jul 5, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jul 4, 2020

Q A
Type improvement
BC Break yes

At this point, all classes under the Driver namespace are either abstract or final.

@morozov morozov added this to the 3.0.0 milestone Jul 4, 2020
@morozov morozov requested a review from greg0ire July 4, 2020 21:45
@morozov morozov merged commit 6055798 into doctrine:3.0.x Jul 5, 2020
@morozov morozov deleted the final-drivers branch July 5, 2020 19:55
@morozov morozov assigned morozov and unassigned greg0ire Jul 5, 2020
@morozov morozov mentioned this pull request Jul 7, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
BC Break Drivers Improvement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire