Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDO connection and statement classes made final #4138

Merged
merged 1 commit into from
Jul 3, 2020
Merged

PDO connection and statement classes made final #4138

merged 1 commit into from
Jul 3, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jul 3, 2020

Q A
Type improvement
BC Break yes

PDOSqlsrv\Connection and PDOSqlsrv\Statement now wrap the corresponding PDO classes instead of extending them, and they all are now final.

@morozov morozov added this to the 3.0.0 milestone Jul 3, 2020
@morozov morozov merged commit 17e6eae into doctrine:3.0.x Jul 3, 2020
@morozov morozov deleted the final-pdo-connection-statement branch July 3, 2020 14:42
@morozov morozov self-assigned this Jul 3, 2020
This was referenced Jul 3, 2020
Merged
Merged
@morozov morozov mentioned this pull request Oct 18, 2020
Closed
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
BC Break Drivers Improvement pdo_sqlsrv PDO
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire