Removed EchoSQLLogger #3934
Merged
Removed EchoSQLLogger #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SenseException
previously approved these changes
Apr 7, 2020
morozov
force-pushed
the
remove-echo-sql-logger
branch
from
59dbfcb
to
d1092da
Compare
morozov
force-pushed
the
remove-echo-sql-logger
branch
from
d1092da
to
d6f66d8
Compare
greg0ire
approved these changes
Apr 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logger doesn't provide any structure around the messages being logged which makes it barely usable even for development. It reasonably pisses off Scrutinizer and requires maintenance during library-wide code modifications.
TODO:
2.11.0(Deprecate EchoSQLLogger #3935).