Refactored MySQLiStatement::$columnNames #3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good! What is still WIP about this? |
|
Nothing about this one specifically. Let me merge #3590 and rebase this one. |
morozov
force-pushed
the
refactor-mysql-statement-column-names
branch
from
5255ecd
to
6040522
Compare
The `$columnNames` property has a too complex type `string[]|false|null` which leads to: 1. Non-trivial to understand conditions and assertions like `if ($columnNames === false)`, `if ($columnNames === true)` and `assert(is_array($columnNames))`. 2. Avoidable [false-positives](https://scrutinizer-ci.com/g/doctrine/dbal/inspections/20d1aea4-2217-4f38-8adc-5ce10fa9cf0b/issues/files/lib/Doctrine/DBAL/Driver/Mysqli/MysqliStatement.php?status=new&orderField=path&order=asc&honorSelectedPaths=0) on Scrutinizer that thinks that `$columnNames` can be TRUE.
morozov
force-pushed
the
refactor-mysql-statement-column-names
branch
from
6040522
to
e4c37f5
Compare
Ocramius
approved these changes
Jan 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$columnNamesproperty has a too complex typestring[]|false|nullwhich leads to:if ($columnNames === false),if ($columnNames === true).assert(is_array($columnNames)).$columnNamescan be TRUE.Making this a non-breaking change requires resolving #3590 first since it declares the
MysqliStatementclassfinal.