Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EM] Merge GPU partitioning with histogram building. #10766

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Aug 30, 2024

  • Stop concatenating pages if there's no subsampling.
  • Use a single iteration for histogram build and partitioning. It's critical to reduce the amount of looping over the cache.

This PR does not include some optimization work, as I want to redo some of the analyses before upstreaming optimizations.

After this PR, the basic framework for GPU batch-based training is considered complete. We will then focus on feature integration and performance optimization.

Todos:

  • Tests
  • Perf check.

Known limitations:

  • Changing sampling during training can lead to issues. We will have a switch to decide whether page concatenation is needed. For now, sampling turns on concatenation automatically.

- Stop concatenating pages if there's no subsampling.
- Use a single iteration for histogram build and partitioning.
@trivialfis trivialfis changed the title [WIP][EM] Merge GPU partitioning and histogram building. [EM] Merge GPU partitioning and histogram building. Aug 30, 2024
@trivialfis trivialfis marked this pull request as ready for review August 30, 2024 08:41
@trivialfis
Copy link
Member Author

cc @rongou .

@trivialfis trivialfis changed the title [EM] Merge GPU partitioning and histogram building. [EM] Merge GPU partitioning with histogram building. Aug 30, 2024
@trivialfis trivialfis merged commit e1a2c1b into dmlc:master Aug 30, 2024
30 checks passed
@trivialfis trivialfis deleted the ext-batches branch August 30, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants