Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ApplicationEmojiManager): fix fetch example #10480

Merged
merged 2 commits into from
Sep 3, 2024
Merged

docs(ApplicationEmojiManager): fix fetch example #10480

merged 2 commits into from
Sep 3, 2024

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Fixes the ApplicationEmojiManager#fetch example, <Message>.application doesn't exist

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@sdanialraza sdanialraza requested a review from a team as a code owner September 3, 2024 21:56
@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 10:10pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 10:10pm

vladfrangu
vladfrangu approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could've also just dropped message from there

@vladfrangu vladfrangu added this to the discord.js 14.16.2 milestone Sep 3, 2024
@kodiakhq kodiakhq bot merged commit 4594896 into discordjs:main Sep 3, 2024
7 checks passed
@sdanialraza sdanialraza deleted the docs/fix-fetch-example branch September 3, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@Jiralite Jiralite Jiralite approved these changes

@almeidx almeidx almeidx approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
documentation packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 14.16.2
Development

Successfully merging this pull request may close these issues.
4 participants
@sdanialraza @vladfrangu @Jiralite @almeidx