fix: failed build in node and bad lints #10444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almeidx
requested review from
monbrey,
vladfrangu,
iCrawl,
almostSouji and
Jiralite
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
almeidx
force-pushed
the
fix/cdb-node-generation
branch
from
8d73e78
to
431598e
Compare
ckohen
reviewed
Aug 14, 2024
vladfrangu
approved these changes
Aug 20, 2024
ckohen
approved these changes
Aug 20, 2024
iCrawl
approved these changes
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10444 +/- ##
=======================================
Coverage 50.91% 50.91%
=======================================
Files 228 228
Lines 20750 20750
Branches 1258 1258
=======================================
Hits 10565 10565
Misses 10141 10141
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Sep 9, 2024
* fix: failed build in node and bad lints * chore: update tsconfigs --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
The typescript build was failing for bots created under node.js due to the usage of
.tsimportsESLint was also failing due to the
strictNullCheckstsconfig option not being enabledAfter fixing the build, prettier was formatting the files in the
distfolderSupersedes #10104
Status and versioning classification: