Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ws): event layout #10376

Merged
merged 3 commits into from
Jul 24, 2024
Merged

refactor(ws): event layout #10376

merged 3 commits into from
Jul 24, 2024

Conversation

didinele
Copy link
Member

@didinele didinele commented Jul 2, 2024

Breaking the whole library.

discord.js needs updating, but it's currently pinned to an older version so that'll have to be a TODO for someone else.

BREAKING CHANGE: All events now emit shard id as its own param
@didinele didinele requested review from a team as code owners July 2, 2024 21:14
Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 6:34pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 6:34pm

@didinele didinele added this to the ws 2.0.0 milestone Jul 2, 2024
@didinele didinele modified the milestones: ws 2.0.0, core 1.3.0 Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 32.75862% with 39 lines in your changes missing coverage. Please review.

Project coverage is 50.73%. Comparing base (fcd35ea) to head (ebc92d7).

Files Patch % Lines
packages/ws/src/ws/WebSocketShard.ts 13.95% 37 Missing ⚠️
packages/ws/src/utils/WorkerBootstrapper.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10376      +/-   ##
==========================================
+ Coverage   50.55%   50.73%   +0.17%     
==========================================
  Files         228      228              
  Lines       20717    20646      -71     
  Branches     1253     1253              
==========================================
+ Hits        10474    10475       +1     
+ Misses      10199    10127      -72     
  Partials       44       44              
Flag Coverage Δ
brokers 64.14% <ø> (ø)
builders 95.78% <ø> (ø)
collection 100.00% <ø> (ø)
formatters 99.34% <ø> (ø)
proxy 78.52% <ø> (ø)
rest 92.68% <ø> (ø)
ws 51.88% <32.75%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit bf6761a into main Jul 24, 2024
25 checks passed
@kodiakhq kodiakhq bot deleted the refactor/ws-events branch July 24, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants