Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): correct typo & update code snippet #626

Merged
merged 3 commits into from
Nov 4, 2022
Merged

fix(docs): correct typo & update code snippet #626

merged 3 commits into from
Nov 4, 2022

Conversation

akrabdev
Copy link
Contributor

@akrabdev akrabdev commented Apr 24, 2022 •
edited
Loading

Noticed a typo in docs @ Core concepts | Scale

Also the usage of v1 api for allocate @ Core concepts | Mutations

@vercel
Copy link

vercel bot commented Apr 24, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dinerojs ❌ Failed (Inspect) Nov 4, 2022 at 9:31PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 24, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bf141c8:

Sandbox Source
@dinero.js/example-cart-react Configuration
@dinero.js/example-cart-vue Configuration
@dinero.js/example-pricing-react Configuration
@dinero.js/example-starter Configuration

@akrabdev akrabdev changed the title fix(docs): correct constant name in scale docs fix(docs): correct typo & update code snippet Apr 25, 2022
johnhooks
johnhooks previously approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@johnhooks johnhooks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, these are both typos, and the suggested changes are correct

@sarahdayan sarahdayan merged commit 8c4d785 into dinerojs:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahdayan sarahdayan sarahdayan approved these changes

@johnhooks johnhooks johnhooks left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akrabdev @sarahdayan @johnhooks