-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve auth flow error handling #1862
Conversation
f7c893d
to
89277ee
Compare
@tkleczek can you please rebase your PR? |
89277ee
to
e816137
Compare
@sagikazarmark done, sorry for the delay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, but overall it looks good! Thanks!
@tkleczek I know this has been in the queue for a long time, but I'd like to release it. Do you think you can take a look at @nabokihms comments? |
Moving to the next milestone |
@sagikazarmark @nabokihms I rebased the PR and fixed code review issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, thanks. I added some NIT comments.
I am going to test this PR. If everything is ok, I will mark it as approved.
Signed-off-by: Tomasz Kleczek <tomasz.kleczek@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only problem I found is that we still see a displayed error on accessing the /auth
endpoint with the wrong connector id. This happens because now we are parsing an auth request only after redirecting to the connector login page.
I don't think this blocks us from accepting this PR as is. Let's merge it. We can deal with the rest later.
@tkleczek thank you for the contribution! |
Overview:
Fixes several unrelated problems related to auth flow error handling
What problem does it solve?:
This PR partially fixes #1796
Special notes for a reviewer: