Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release type for github workflows, switch to new auth #146

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

SlouchyButton
Copy link
Collaborator

@SlouchyButton SlouchyButton commented Aug 20, 2024

workflow_dispatch: allows us to start the workflow manually in case something fails.

Type published fires only when actually publishing the release. create also fires when draft is created/saved, so when you upload files to the release, it will automatically save it as draft. For security reasons, GitHub doesn't start workflow when create event is fired, if it doesn't also publish the release at the same time.

This can seemingly work in some repositories where no additional files are uploaded when doing the release, but that's not the case here.

https://docs.github.com/en/webhooks/webhook-events-and-payloads#release
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#release

From GitHub docs:

Note: Workflows are not triggered for the created, edited, or deleted activity types for draft releases. When you create your release through the GitHub browser UI, your release may automatically be saved as a draft.

PR also removes the password field as PyPi uses new auth methods.

@phracek phracek merged commit d2f7c0a into devexp-db:main Aug 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants