fix(ext/node): discover .npmrc in user's homedir #24021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also add support for the other locations? According to the docs there is a total of 4 locations to check:
|
The last one makes no sense, because we're not npm and the "global" one has not been mentioned even once in #16105. I think we're fine with just per-project and per-user. Some tools like Renovate don't even support per-user config. |
|
Fair point. Per project + per user probably covers 99% of use cases. |
marvinhagemeister
approved these changes
May 31, 2024
sbmsr
pushed a commit
to sbmsr/deno-1
that referenced
this pull request
Jul 2, 2024
This commit adds discovery of `.npmrc` files in user's homedir. This is not a perfect fix as it doesn't merge multiple `.npmrc` files together as per denoland#23954 but allows to fallback if no `.npmrc` file is discovered in the project root.
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
This commit adds discovery of `.npmrc` files in user's homedir. This is not a perfect fix as it doesn't merge multiple `.npmrc` files together as per denoland#23954 but allows to fallback if no `.npmrc` file is discovered in the project root.
|
Doesn't this potentially conflict with JSR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds discovery of
.npmrcfiles in user's homedir.This is not a perfect fix as it doesn't merge multiple
.npmrcfilestogether as per #23954
but allows to fallback if no
.npmrcfile is discovered in the projectroot.