-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: a11y: keyboard navigation: add outline and focusability #4005
Conversation
81002a3
to
2034198
Compare
The chat background color picker, with keyboard, from the main screen
This improves keyboard usage experience (accessibility, a11y) For the most part this does not affect items that are focused with mouse instead of keyboard (apart from "advanced" login fields, and maybe some other places), all thanks to `:focus-visible` selector https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible#focus_vs_focus-visible Composer, message search, settings, contact search are not affected for pointer device users. For reference, here are some commits that had to do with `outline` and `:focus`. They don't appear to be paying much attention to keyboard-accessibility: - b740c60 - b5fb8a0 - 0c7949c - 11bda12 - 9307958
2034198
to
4aa5082
Compare
is the outline always visible or only after tab is hit? is there a selector for high-contrast or accessibility maybe? what do others (signal, whatsapp) do here? |
I'm not sure if there is a way to set
Only after Tab is hit. It's won't appear if you're just using a mouse.
I believe so. |
Signal appears to behave the same, but they do it programmatically, by dynamically adding |
See commit messages
I tested it. Appears to be working good, but some rarely used elements might get ugly even for mouse-only navigation.
This by no means makes DC fully keyboard-accessible, but it's an improvement.