take message-image height from core into account #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
commented
Dec 10, 2019
| @@ -145,7 +145,6 @@ | |||
| object-fit: cover; | |||
| width: auto; | |||
| max-width: 100%; | |||
| height: 400px; | |||
There was a problem hiding this comment.
that was always overwritten by the max height .module-message__img-attachment so I removed it.
Simon-Laux
changed the title
Jikstra
reviewed
Dec 10, 2019
| @@ -168,7 +165,7 @@ export default function Attachment (props) { | |||
| > | |||
| <video | |||
| className='module-message__img-attachment' | |||
| height={Math.min(MAXIMUM_IMG_HEIGHT, height)} | |||
| style={{ height: `${Math.min(MAXIMUM_IMG_HEIGHT, height)}px` }} | |||
There was a problem hiding this comment.
Math.min(MAXIMUM_IMG_HEIGHT, height) + 'px'
Jikstra
force-pushed
the
image_sizing
branch
from
d8597dd
to
40ac17b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still doesn't completely beautifies the image dimensions, but it doesn't hurt and it revives dead code...
relies on deltachat/deltachat-node#397