Update all dc.mixin docs #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lot of missing documentation to the baseMixin. Added default implementation examples,
@seelinks (notably to other functions of interest & crossfilter/d3/HTML/SVG docs), and after a review of the current JSDoc implementation, updates references that returnedChartto just returndc.baseMixin. UsingChartseems a bit unnecessary, since we should just be linking back to thedc.baseMixin(plan to update the other mixin/charts with this as well).Depending on timeframe, I may get to the other mixins/charts this week as well, so I may rename the title and the changeset will grow.
Interesting to document some of these things I didn't know existed or only work under some circumstances; guess I just don't use some of these things that often or take the functionality for granted...