Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated resource urls, fixed mixed content loading #1529

Closed
wants to merge 1 commit into from

Conversation

ron4stoppable
Copy link
Contributor

resolves issue with mixed content loading, http content over https; in example

resolves issue with mixed content loading, http content over https; in example
@gordonwoodhull
Copy link
Contributor

Thank you @ron4stoppable. I see the error in Firefox but not Chrome, and it prevents the page from running.

Wonder why it's not an issue with the rest of the examples, which load dc.js over http in header.js. Maybe because the same script is also loaded normally. I'm seeing a warning about document.write so we should at least remove the scripts from the document.write.

@ron4stoppable
Copy link
Contributor Author

ron4stoppable commented Jun 15, 2019

@gordonwoodhull I got the error on chrome (73.0.3683.86), might be because of poor network. I'll check document.write in other examples too.

@gordonwoodhull
Copy link
Contributor

Thanks @ron4stoppable, merged for 3.1 (also fixed the one in header.js).

I was able to repro on Chrome as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants