-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for dc.lineChart.curve. Deprecating interpolate/tension. #1381
Conversation
src/line-chart.js
Outdated
} | ||
|
||
if (_tension && typeof curve.tension === 'function') { | ||
curve = curve.tension(_tension); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a warning here if _tension
was specified but the curve doesn't support it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While fixing also realized that 0 is a valid value for _tension, which would have gotten discarded.
This is really solid, careful work. Just one more backward-compatibility warning would help, I think. Thank you for all your efforts. |
Thanks @gordonwoodhull, will add the warning soon. Currently deep into the zoom behavior. |
Thanks @kum-deepak! Made some tweaks and merged. |
Thanks @gordonwoodhull, all your changes make sense! Any suggestions what I should pick up next? |
Thanks @kum-deepak, please review your comments and Upgrade Notes from #1363 and see if there is anything else you want to address. After that, please start looking at the 4 PRs I listed there, which I believe are ready to go, but need to be ported to d3v4. I have not thoroughly reviewed them, so if you see anything that needs improvement, go for it. I think they are ready because they have passing automated tests and most of them have also been tested by people beside the author. I will look at the transition issues and Congratulations, and thank you! |
Resolves #1376
Updated documentation and code examples. Looking forward to your feedback.