Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make bracket selectors work with quoted values #1282

Closed
wants to merge 1 commit into from

Conversation

IwfY
Copy link
Contributor

@IwfY IwfY commented Feb 21, 2017

This change allows coordinate grid chart's root element to be something like '.chart[foo="5bar"]'.

Before only selectors like '.chart[foo=bar]' worked but if the value starts with a number it must be quoted which was not possible to use with dc.js due to the way the clip path id was generated.

that allows chart's root element to be something like '.chart[foo="5bar"]'
@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Mar 30, 2017
@gordonwoodhull
Copy link
Contributor

Thanks @IwfY! Merged to 2.0.2 (and will be merged to later versions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants