Fix legend item wrapping for _horizontal #1229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug, which lead to not wrapping the legend if the _legendWidth was exceeded.
|
Thanks @alexnb and sorry for the slow response. I take it the bug exhibited as the row wrapping too late, i.e. an extra item gets displayed on each row and pushes out of bounds? I'm going to try adding a failing test that will get fixed by this. |
|
I was able to confirm the bug in a test, and merged your fix for v2.0. Thanks @alexnb! It was a sophisticated kind of off-by-one error, and in reviewing this I noticed that we deliberately didn't test this feature well enough when merging it. Partly I've just gotten better at writing tests (or more patient). Partly it's messy to test anything involving text because the sizes can come out wildly different (especially on PhantomJS). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug, which lead to not wrapping the legend if the _legendWidth was exceeded.