Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower.json: wrong d3 dependency for v3.04 #1458

Closed
silentmantra opened this issue Jun 28, 2018 · 5 comments
Closed

bower.json: wrong d3 dependency for v3.04 #1458

silentmantra opened this issue Jun 28, 2018 · 5 comments

Comments

@silentmantra
Copy link

v3.04 uses d3.timeFormat, that was introduced in d3 v4.x
however the bower.json contains a dependency to d3 v3.x.

@devleaks
Copy link

Please keep bower.json in sync with package.json
(as today: package.json has "crossfilter2": "^1.4.5", "d3": "^5.4.0", while bower still "d3": "3.x", "crossfilter2": "~1.4")
Thank you.

@seantai-mitre
Copy link

Is there any plan for this to be updated? It seems like the bower.json is still out of date in its d3 dependency.

@gordonwoodhull
Copy link
Contributor

Sorry, bower is not on my radar, obviously.

I'll correct this in the next release, and see if it can be generated from package.json somehow.

@seantai-mitre
Copy link

Cool, thanks!

@gordonwoodhull gordonwoodhull changed the title wrong d3 dependency for v3.04 bower.json: wrong d3 dependency for v3.04 Oct 28, 2019
@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Oct 28, 2019

Sorry for the extreme delay.

I'm updating bower.json in version 3.1.7 and deprecating Bower support - dc.js version 4 will not support Bower. Please make sure to specify version 3.x if you are using Bower.

gordonwoodhull added a commit that referenced this issue Dec 16, 2019
once again, please specify dc version 3.x if you are using bower

fixes #1458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants