Support running dump_object multiple times in single execution #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…single execution, this var prevents items from being exported in subsequent files without clearing
|
@davedash Any thoughts on this? |
|
Looks good, can you fixup the weird whitespace issues? Otherwise I can take care of it later. |
|
heh... Sorry that was me pep-8ing. I believe that that's the recommended indent using brackets for include. |
|
I'm fine to change it back tho if you'd rather that. |
|
Oh nm, no pep8 good. I was confused by the diff highlighter. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my workflow, I run dump_object many times in a single execution... The gotcha I hit was the seen dict was never getting cleared, meaning that subsequent calls would be missing things that should be exported. This fix addresses that.