dont save moe lb-loss tensors if args.moe_loss_weight=0 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it takes GPU memory, and can also cause a leak if clear_load_balancing_loss() is not called
mihir-db
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Megablocks accumulates lb-loss tensors here and expects the user to call
clear_load_balancing_loss()to release the memory. In our case we compute the lb-loss outside of Megablocks and had a GPU memory leak before we noticed this behaviour.We can call
clear_load_balancing_loss()after every Megablocksforward(), but it's even better to just avoid accumulating these tensors if Megablocks' lb-loss calculation is not needed - which can already be signaled by passing 0 toArguments.args.moe_loss_weight