FB BatchSource Plugin #4

amolkokane-cirus · 2020-06-11T11:52:28Z

FB BatchSource Plugin

googlebot · 2020-06-11T11:52:46Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

amolkokane-cirus · 2020-06-11T14:12:58Z

@googlebot I signed it!

googlebot · 2020-06-11T14:13:12Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

shiva-cirus · 2020-06-11T16:31:28Z

@googlebot I consent.

rmstar · 2020-06-26T00:27:10Z

pom.xml

+    <dependency>
+      <groupId>io.cdap.cdap</groupId>
+      <artifactId>cdap-etl-api</artifactId>
+      <version>${cdap.version}</version>


scope should be provided
https://github.com/data-integrations/google-cloud/blob/develop/pom.xml#L148
Please take a look at above pom file for scope of the artifacts

rmstar · 2020-06-26T00:41:29Z

src/test/java/io/cdap/plugin/facebook/etl/FacebookBatchSourceTest.java

+
+    adSets.add(result);
+
+    return result;


return value is unused?

CuriousVini · 2020-07-30T17:30:13Z

src/main/java/io/cdap/plugin/facebook/source/common/AdsInsightsTransformer.java

+          fieldSchema = fieldSchema.getNonNullable();
+        }
+
+        switch (fieldSchema.getType()) {


why other types are not supported like integer, double, date, timestamp etc

We are not sure why the original developers not support those types. Let me know if you want me to add a TO DO here. Facebook Ads plugins needs a lot of changes and is not very useful in the correct form. This feedback was provided to Bhooshan from our testing also also from P&G testing.

Please add TODO with corresponding jira

Code Updated with TODO and created JIRA ticket - https://issues.cask.co/browse/PLUGIN-365

CuriousVini · 2020-07-31T13:51:34Z

src/main/java/io/cdap/plugin/facebook/source/batch/FacebookInputFormat.java

+public class FacebookInputFormat extends InputFormat {
+  @Override
+  public List<InputSplit> getSplits(JobContext jobContext) {
+    return Collections.singletonList(new FacebookSplit());


This is using single split. Could you create a jira for it and add a TODO with the jira number here?

Bump checkstyle from 6.19 to 8.29 Updated FB API version to 6.0.3 and added missing javadoc Updated FB API version to 7.2.0 and changed copyright to 2020 Modified to implement PR comments Add TODO's in code based on PR feedback

googlebot · 2020-08-06T21:10:49Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

rmstar self-requested a review June 26, 2020 00:24

rmstar approved these changes Jul 9, 2020

View reviewed changes

CuriousVini reviewed Jul 30, 2020

View reviewed changes

CuriousVini approved these changes Jul 30, 2020

View reviewed changes

CuriousVini reviewed Jul 31, 2020

View reviewed changes

CDAP-15860 Facebook Ads (SaaS source) - batch source

1a2bba5

Bump checkstyle from 6.19 to 8.29 Updated FB API version to 6.0.3 and added missing javadoc Updated FB API version to 7.2.0 and changed copyright to 2020 Modified to implement PR comments Add TODO's in code based on PR feedback

shiva-cirus force-pushed the wip_develop branch from 2e09812 to 1a2bba5 Compare August 6, 2020 21:10

CuriousVini merged commit 50e3e23 into data-integrations:develop Aug 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FB BatchSource Plugin #4

FB BatchSource Plugin #4

amolkokane-cirus commented Jun 11, 2020 •

edited

Loading

googlebot commented Jun 11, 2020

amolkokane-cirus commented Jun 11, 2020

googlebot commented Jun 11, 2020

shiva-cirus commented Jun 11, 2020

rmstar Jun 26, 2020

amolkokane-cirus Jul 13, 2020

rmstar Jun 26, 2020

amolkokane-cirus Jul 13, 2020

CuriousVini Jul 30, 2020

shiva-cirus Jul 30, 2020

CuriousVini Jul 30, 2020

shiva-cirus Jul 30, 2020

CuriousVini Jul 31, 2020

googlebot commented Aug 6, 2020

FB BatchSource Plugin #4

FB BatchSource Plugin #4

Conversation

amolkokane-cirus commented Jun 11, 2020 • edited Loading

googlebot commented Jun 11, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

amolkokane-cirus commented Jun 11, 2020

googlebot commented Jun 11, 2020

shiva-cirus commented Jun 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

googlebot commented Aug 6, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

amolkokane-cirus commented Jun 11, 2020 •

edited

Loading